Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace SheetBottom with BottomSheet in SDKFeedbackModal #8445

Merged
merged 3 commits into from
Jan 30, 2024
Merged

refactor: Replace SheetBottom with BottomSheet in SDKFeedbackModal #8445

merged 3 commits into from
Jan 30, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

Replace SheetBottom with BottomSheet in SDKFeedbackModal

Related issues

Fixes: #8428

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Jan 29, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 29, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 29, 2024 05:26
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (266154a) 40.42% compared to head (d5c0c57) 40.42%.

Files Patch % Lines
...onents/Views/SDKFeedbackModal/SDKFeedbackModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8445   +/-   ##
=======================================
  Coverage   40.42%   40.42%           
=======================================
  Files        1239     1239           
  Lines       29976    29976           
  Branches     2869     2869           
=======================================
  Hits        12117    12117           
  Misses      17168    17168           
  Partials      691      691

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgewrmarshall
georgewrmarshall previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

app/components/Views/SDKFeedbackModal/SDKFeedbackModal.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 8ec6610 into main Jan 30, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the bottomsheet/sdkfeedbackmodal branch January 30, 2024 01:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 30, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MOB] Replace SheetBottom with BottomSheet in SDKFeedbackModal
4 participants
@brianacnguyen @codecov-commenter @georgewrmarshall @metamaskbot